Update LGCP notebook to v4 #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Member
|
NB looks good, but pre-commit. Probably need to update myst file. |
Member
|
There is a typo caught by codespell check: https://github.com/pymc-devs/pymc-examples/runs/6758385057?check_suite_focus=true#step:5:84. "accomodate" only has one m and is being updated to "accommodate" |
OriolAbril
reviewed
Jun 7, 2022
OriolAbril
approved these changes
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to updating to v4, I removed the second model from the notebook. The first model already takes upward of an hour to run on a reasonably fast PC; the second model takes almost a day.
The notebook has also been moved from the case studies folder to the gaussian processes folder.